search

cta-observatory / lstmcpipe

Scripts to analyse MC files on LST cluster at La Palma
https://cta-observatory.github.io/lstmcpipe/
MIT License
7 stars 15 forks source link

Voutsi seasonal atmosphere #435

Closed vuillaut closed 1 year ago

vuillaut commented 1 year ago

Duplicate of #432 for tests

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (f50cf26) 31.89% compared to head (d828874) 31.89%. Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #435 +/- ## ======================================= Coverage 31.89% 31.89% ======================================= Files 46 46 Lines 2841 2841 ======================================= Hits 906 906 Misses 1935 1935 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

vuillaut commented 1 year ago

@Voutsi Sorry I had to duplicate your PR for tests requiring internal data

Could you have a look at the config please? It seems not to be valid https://github.com/cta-observatory/lstmcpipe/actions/runs/6630900759/job/18013284433?pr=435

Voutsi commented 1 year ago

Hi @vuillaut

you are right, thanks, there was an indentation error. I fixed it in the original PR, it seems that I don't have permissions to push something here.

vuillaut commented 1 year ago

Hi @vuillaut

you are right, thanks, there was an indentation error. I fixed it in the original PR, it seems that I don't have permissions to push something here.

You should request Max or Karl to be added to cta-observatory github organisation so I can add you to lst-dev and then you will be able to create branches directly in this repo to allow unit tests to run for your PRs. In the meantime I will synch with you branch.

Voutsi commented 1 year ago

I see, it detects some tab characters that it doesn't accept. I will fix it.

Voutsi commented 1 year ago

So it seems the problem is fixed. I launched the command lstmcpipe -c config_MC_prod.yml -conf_lst lstchain_*.json and it reached the stage Are you sure ? [y/N] If I understood well, that should mean the the configuration is valid

vuillaut commented 1 year ago

So it seems the problem is fixed. I launched the command lstmcpipe -c config_MC_prod.yml -conf_lst lstchain_*.json and it reached the stage Are you sure ? [y/N] If I understood well, that should mean the the configuration is valid

Hi You can validate the config using lstmcpipe_validate_config command

vuillaut commented 1 year ago

seems good now

vuillaut commented 1 year ago

Prod is done @Voutsi