search

cta-observatory / nectarchain

NectarCAM high level analysis tools
https://nectarchain.readthedocs.io
BSD 3-Clause "New" or "Revised" License
7 stars 18 forks source link

Lint does not run in CI #137

Closed jlenain closed 3 months ago

jlenain commented 3 months ago

Describe the bug The code is not linted in CI.

To Reproduce Steps to reproduce the behavior:

  1. Open a PR
  2. Check the runner logs
  3. All linting steps are skipped

Expected behavior The pre-commit hooks should be run in CI

Supporting information See e.g. https://github.com/cta-observatory/nectarchain/actions/runs/10144120767/job/28046944606

[...]
Run pre-commit run --show-diff-on-failure --color=always --files $(git diff origin/main --name-only)
fatal: ambiguous argument 'origin/main': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
isort................................................(no files to check)Skipped
black-jupyter........................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
jupytext.............................................(no files to check)Skipped