search

cta-observatory / nectarchain

NectarCAM high level analysis tools
https://nectarchain.readthedocs.io
BSD 3-Clause "New" or "Revised" License
7 stars 18 forks source link

Added final test (final version of user script before I leave) #158

Closed dmousadi closed 1 day ago

dmousadi commented 1 week ago

Hi, sorry for the consecutive pull request, but today is my last day at CEA and I thought I should add the final version of the tests. I have added the test for the trigger timing requirement and made some changes to the gui. If there is anything that I need to change, please let me know.

jlenain commented 1 day ago

Hi @dmousadi ,

Thank you very much for this. At the moment, this PR has conflicts with our main branch, and I am in no position to judge which should take precedence. Could you please fix these ?

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 47.51%. Comparing base (b306f30) to head (ce13435). Report is 32 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #158 +/- ## ========================================== + Coverage 40.76% 47.51% +6.74% ========================================== Files 65 64 -1 Lines 4452 4590 +138 ========================================== + Hits 1815 2181 +366 + Misses 2637 2409 -228 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dmousadi commented 1 day ago

Hi, I resolved the conflicts, the correct ones were the newer versions of the files. Sorry for the multiple commits, but it wasn't passing the hooks because of some spaces and I was trying to fix it via online editor to save time, because I haven't installed nectarchain on the computer I am currently using. Let me know if I need to change something else!

jlenain commented 1 day ago

Thanks a lot, @dmousadi !