Fix calibration benchmarking settings

cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory

Other

5 stars 13 forks source link

Description

There was a typo in the JSON configuration file for the generation of 2nd-pass reconstructed images produced with the TwoPassWindowSum image extractor.

This typo has been found in the image cleaning settings, which define the cleaning thresholds for the preliminary image cleaning in-between the 2 passes and it mistakenly discarded pixels by applying a +10 photoelectrons difference,

"TwoPassWindowSum": {
        "core_threshold" : [
          ["type", "*", 6.0],
          ["type", "LST_LST_LSTCam", 16.0],       -----> ["type", "LST_LST_LSTCam", 6.0],
          ["type", "MST_MST_NectarCam", 18.0]     -----> ["type", "MST_MST_NectarCam", 8.0]
        ],

Consequences

The optimized cleaning thresholds for the reference analysis (#24) will change as follows,

LSTCam : (7.24, 3.62)      ---> (6.61, 3.30)
NectarCam : (6.92, 3.46)   ---> (5.75, 2.88)

This will

update the information stored here regarding exclusively the 2nd pass,
have (hopefully positive) consequences on the results stored here.

Codecov Report

Merging #100 (f7638a6) into master (5b2a815) will not change coverage. The diff coverage is n/a.

@@ Coverage Diff @@ ## master #100 +/- ## ======================================= Coverage 36.81% 36.81% ======================================= Files 18 18 Lines 1798 1798 ======================================= Hits 662 662 Misses 1136 1136

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b2a815...1ffaf4e. Read the comment docs.

cta-observatory / protopipe