cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Small improvements to modeling script #114

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

This PR is the result of some improvement that came out as a consequence of the development of the integration tests for the modeling part.

codecov[bot] commented 3 years ago

Codecov Report

Merging #114 (e87557c) into master (e708fe7) will decrease coverage by 0.61%. The diff coverage is 9.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage   39.22%   38.61%   -0.62%     
==========================================
  Files          22       22              
  Lines        1912     1950      +38     
==========================================
+ Hits          750      753       +3     
- Misses       1162     1197      +35     
Impacted Files Coverage Δ
protopipe/mva/train_model.py 15.68% <ø> (ø)
protopipe/scripts/build_model.py 11.29% <2.50%> (-3.93%) :arrow_down:
protopipe/pipeline/utils.py 50.90% <22.22%> (-1.66%) :arrow_down:
protopipe/mva/utils.py 12.31% <50.00%> (+0.97%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e708fe7...e87557c. Read the comment docs.