cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Setup of pipeline integration testing up to modeling #116

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

Requirements

Description

This PR refactors integration tests in a single module called test_pipeline.py where,

codecov[bot] commented 3 years ago

Codecov Report

Merging #116 (bf85742) into master (e87557c) will increase coverage by 7.69%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   38.61%   46.30%   +7.69%     
==========================================
  Files          22       22              
  Lines        1950     1978      +28     
==========================================
+ Hits          753      916     +163     
+ Misses       1197     1062     -135     
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/pipeline/utils.py 54.54% <0.00%> (+3.63%) :arrow_up:
protopipe/pipeline/event_preparer.py 76.62% <0.00%> (+7.27%) :arrow_up:
protopipe/mva/utils.py 30.43% <0.00%> (+18.11%) :arrow_up:
protopipe/mva/train_model.py 60.78% <0.00%> (+45.09%) :arrow_up:
protopipe/scripts/build_model.py 61.29% <0.00%> (+50.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7632ef2...bf85742. Read the comment docs.

HealthyPear commented 3 years ago

@kosack did you notice PR #114 ? I can't merge this one before because I am using some of the new flag options in the model script