search

cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Fix classifier integration test #120

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

Requirements

Description

This PR fixes an error in the pipeline's testing workflow for which the testing function for the classifier(s) was actually using the energy regressor configuration file, thus not even using protons.

Caveat

Once this fix has been added the same integration test found an error in the execution of the script to build the models, so right now this PR cannot be merged until that error is fixed in a different PR (but it can be pre-reviewed).

codecov[bot] commented 3 years ago

Codecov Report

Merging #120 (ac3c4a4) into master (4c7a7fe) will increase coverage by 2.35%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   47.61%   49.97%   +2.35%     
==========================================
  Files          22       22              
  Lines        1995     1995              
==========================================
+ Hits          950      997      +47     
+ Misses       1045      998      -47
Impacted Files Coverage Δ
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)
protopipe/scripts/build_model.py 86.61% <0.00%> (+25.98%) :arrow_up:
protopipe/mva/train_model.py 88.23% <0.00%> (+27.45%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c7a7fe...ac3c4a4. Read the comment docs.