search

cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Add concentration #133

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

In this PR concentration is added to the output of the EventPreparer class, so it is written out to TRAINING and DL2 formats.

It is only computed for the extended image (aka with all clusters)

ctapipe outputs concentration in 3 different definitions, none of which seem to coincide with the one used by CTAMARS, but we can use

concentration_pixel = image.max() / h.intensity

as a good approximation

codecov[bot] commented 3 years ago

Codecov Report

Merging #133 (f88d9ad) into master (9149e12) will increase coverage by 0.16%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   60.30%   60.46%   +0.16%     
==========================================
  Files          23       23              
  Lines        2091     2102      +11     
==========================================
+ Hits         1261     1271      +10     
- Misses        830      831       +1
Impacted Files Coverage Δ
protopipe/scripts/write_dl2.py 82.45% <ø> (ø)
protopipe/pipeline/event_preparer.py 69.88% <88.88%> (+0.53%) :arrow_up:
protopipe/scripts/data_training.py 94.94% <100.00%> (+0.07%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9149e12...f88d9ad. Read the comment docs.