cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Some broken benchmarks #180

Open kosack opened 2 years ago

kosack commented 2 years ago

Describe the problem

A few benchmarks are broken, and need some updates to fix.

To Reproduce**

TRAINING/benchmarks_DL1_image_intensity_resolution

ImportError: cannot import name 'CTAMARS_radii' from 'protopipe.pipeline.utils' (/Users/kkosack/Projects/CTA/Working/protopipe/protopipe/pipeline/utils.py)

TRAINING/benchmarks_R0_R1_waveforms_pre-calibration

TRAINING/benchmarks_DL2_to_energy-estimation

Exception encountered at "In [12]":
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/var/folders/dv/rg9cnf0d3qg6n5khk1d7yjyxqg1x5k/T/ipykernel_25276/2934236983.py in <module>
     16                'label': 'E [{:.2f},{:.2f}] TeV'.format(true_energy_bin_edges[jdx], true_energy_bin_edges[jdx+1]),
     17                'ms': 6}
---> 18         plot_profile(ax, data=data_sel,
     19                      xcol='impact_dist', ycol='hillas_intensity',
     20                      n_xbin=xbins, x_range=xrange, logx=True, **opt)

ValueError: 'i' is not a valid value for color

TRAINING/benchmarks_DL2_to_classification

/var/folders/dv/rg9cnf0d3qg6n5khk1d7yjyxqg1x5k/T/ipykernel_25420/1308642254.py in <module>
      1 # Read configuration file for particle classification model
      2 model_configuration_path = Path(analyses_directory) / analysis_name / "configs" / model_configuration_filename
----> 3 model_configuration = load_config(model_configuration_path)
      4
      5 # Read feature list from model configutation file

NameError: name 'load_config' is not defined

seems missing import

MODELS/benchmarks_MODELS_classification

Crashes. The model seems to have built ok though.

---------------------------------------------------------------------------
Exception encountered at "In [24]":
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
/var/folders/dv/rg9cnf0d3qg6n5khk1d7yjyxqg1x5k/T/ipykernel_25648/404696727.py in <module>
     29         )
     30
---> 31         PrecisionRecallDisplay.from_estimator(diagnostic[camera].model,
     32                                     selected_test_data[features].to_numpy(),
     33                                     selected_test_data[cfg["Method"]["target_name"]],

ValueError: Found array with 0 sample(s) (shape=(0, 8)) while a minimum of 1 is required.

setup

protopipe dev version (0.4.0.post2.dev401+g1f392ea.d20220315)

HealthyPear commented 2 years ago

Also #173 needs to be added to this list