search

cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

PyPI upload doesn't work anymore #191

Open HealthyPear opened 2 years ago

HealthyPear commented 2 years ago

The new release v0.5.0 is not on PyPI.

Debugging the problem I can see that in the first attempt the uploaded version results in v0.0.0 which is of course wrong https://github.com/cta-observatory/protopipe/actions/runs/2168145005/attempts/1

I think the problem is that setuptools_scm is not supported by the current deploy workflow, which is in fact different from that of ctapipe (the last but one release was so old that this was not a problem...) https://github.com/cta-observatory/ctapipe/blob/0612a333c87cbb7c39b3a82c4663082e77eceb72/.github/workflows/deploy.yml#L22-L26

kosack commented 2 years ago

opened #192 to attempt to fix this

HealthyPear commented 2 years ago

the problem is that the workflow gets triggered only by a tag pushed as "v*" (a release with this name triggers it)

that PR alone won't cut it...