cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Rollback for GRID support #52

Closed HealthyPear closed 4 years ago

HealthyPear commented 4 years ago

When I added protopipe.pipeline.utils.prod3b_array I made some changes that influenced the grid interface code. Since at the time the GRID support was put on hold, I didn't even think that it could be a problem. Indeed since the 2 repos are de facto separated, there was no automatic test to catch this...

The following changes have been rolled back now:

Other changes: I also added a comment about using absolute paths when defining the simtel files lists to be used. This is useful since I plan to enable the use of a container and the paths could be different from my personal setup.

Note: we should check if something like protopipe.pipeline.utils.prod3b_array already exists in ctapipe for Prod3b, otherwise it would be wise to add it, at least for Prod5 (issue to be opened soon to be sure).

codecov[bot] commented 4 years ago

Codecov Report

Merging #52 into master will decrease coverage by 0.00%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
- Coverage    0.40%   0.39%   -0.01%     
=========================================
  Files          20      20              
  Lines        2232    2268      +36     
=========================================
  Hits            9       9              
- Misses       2223    2259      +36     
Impacted Files Coverage Δ
protopipe/pipeline/utils.py 0.00% <0.00%> (ø)
protopipe/scripts/write_dl1.py 0.00% <ø> (ø)
protopipe/pipeline/event_preparer.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c46571c...ac7bd3c. Read the comment docs.