cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory

https://protopipe.readthedocs.io/en/latest/

Other

5 stars 13 forks source link

Upgrade calibration benchmarks #59

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

Description:

now we don't need protopipe for this part, we can use directly ctapipe-stage1-process with proper configuration to mimic CTA-MARS
added a new method to find optimized cleaning thresholds which substitutes the old one
all Prod3b cameras are now supported (but some, like e.g. FlashCam, not optimized)

TO DO

[x] complete tests
[x] fix Travis error finding config file
[x] Update documentation
[x] Merge #58

review-notebook-app[bot] commented 3 years ago

Check out this pull request on

Review Jupyter notebook visual diffs & provide feedback on notebooks.

Powered by ReviewNB

codecov[bot] commented 3 years ago

Codecov Report

Merging #59 (d4d31bb) into master (3225536) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   31.66%   31.66%           
=======================================
  Files          20       20           
  Lines        2201     2201           
=======================================
  Hits          697      697           
  Misses       1504     1504

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3225536...d4d31bb. Read the comment docs.

HealthyPear commented 3 years ago

I might have mistakenly removed an image cleaning benchmark, but it was anyway an older version with respect the one contained in PR #76 .

Please, until PR #62 don't mind the readthedocs check as it is broken at this stage (and is anyway only a nice thing I wanted to add as a backup for the docs).

review-notebook-app[bot] commented 3 years ago

View / edit / reply to this conversation on ReviewNB

kosack commented on 2020-12-01T11:18:09Z ----------------------------------------------------------------

For accessing tables in DL1 files, you should now use read_table (which reads and returns an astropy Table directly, no need for extra conversion, and units are handled automatically:

from ctapipe.io import read_table

all_mc_images = read_table(filename, "/simulation/event/telescope/images")

For loading all the telescope tables, it's also easy, since you can load the subarray first:

subarray = SubarrayDescription.from_hdf(filename)

for tel_id in subarray.tel_ids:

tab = read_table(filename, f"/dl1/event/telescope/images/tel_{tel_id:03d}")