cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Upgrade all other notebooks and their docs version #76

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

Summary description

Note

Due to some dependencies conflict between ctapipe >= 0.9.1 (and its dependencies) and the old version of gammapy used by the old version of the performnce step, I decided to add the pyirf support directly to the next version.

This means that,

Requirements

TODOs

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 3 years ago

Codecov Report

Merging #76 (f4ceedf) into master (70cdb0b) will decrease coverage by 0.17%. The diff coverage is 26.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   36.99%   36.81%   -0.18%     
==========================================
  Files          17       18       +1     
  Lines        1768     1798      +30     
==========================================
+ Hits          654      662       +8     
- Misses       1114     1136      +22     
Impacted Files Coverage Δ
protopipe/mva/utils.py 11.34% <0.00%> (ø)
protopipe/perf/utils.py 24.52% <0.00%> (-0.97%) :arrow_down:
protopipe/scripts/build_model.py 15.21% <ø> (ø)
protopipe/scripts/model_diagnostic.py 6.76% <ø> (ø)
protopipe/perf/temp.py 26.47% <26.47%> (ø)
protopipe/scripts/make_performance_EventDisplay.py 21.78% <40.00%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 70cdb0b...f4ceedf. Read the comment docs.