search

cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Towards using Pyirf #79

Closed gaia-verna closed 3 years ago

gaia-verna commented 3 years ago

Related to first point in #73

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

HealthyPear commented 3 years ago

Also, maybe add a couple of lines in the docs under perf about these changes

gaia-verna commented 3 years ago

We will update the docs in the next PR in which we plan to add the script to produce the performance using pyirf

gaia-verna commented 3 years ago

Remember to update the EventDisplay main part from pyirf example once the new release is out, because we have recently updated it

Yes we will do it in the next PR because here we are not uploaded the make_performance_pyirf file

HealthyPear commented 3 years ago

Remember to update the EventDisplay main part from pyirf example once the new release is out, because we have recently updated it

Yes we will do it in the next PR because here we are not uploaded the make_performance_pyirf file

Sorry my bad - I had forgot the scope of this PR

codecov[bot] commented 3 years ago

Codecov Report

Merging #79 (9f67772) into master (d7a9b90) will decrease coverage by 0.12%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   30.91%   30.78%   -0.13%     
==========================================
  Files          20       20              
  Lines        2258     2267       +9     
==========================================
  Hits          698      698              
- Misses       1560     1569       +9
Impacted Files Coverage Δ
protopipe/perf/cut_optimisation.py 9.68% <0.00%> (+0.08%) :arrow_up:
protopipe/perf/irf_maker.py 14.49% <0.00%> (ø)
protopipe/scripts/make_performance.py 10.75% <0.00%> (ø)
protopipe/scripts/write_dl2.py 5.63% <0.00%> (-0.27%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d7a9b90...9f67772. Read the comment docs.