cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Performance using Pyirf #83

Closed gaia-verna closed 3 years ago

gaia-verna commented 3 years ago

This PR requires #79 and is related to part of #73. News:

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

HealthyPear commented 3 years ago

Small spoiler/request before this PR becomes rewieable:

In #76 I have moved all notebooks under docs/contribution/benchmarks.

I would like you to,

EDIT: I just realized that the new notebook has already "_pyirf" as a suffix, so just move it to the new folder.

codecov[bot] commented 3 years ago

Codecov Report

Merging #83 (db8d430) into master (f0d73e6) will increase coverage by 6.20%. The diff coverage is 24.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   30.78%   36.99%   +6.20%     
==========================================
  Files          20       17       -3     
  Lines        2267     1768     -499     
==========================================
- Hits          698      654      -44     
+ Misses       1569     1114     -455     
Impacted Files Coverage Δ
protopipe/scripts/make_performance_EventDisplay.py 21.49% <21.49%> (ø)
protopipe/perf/utils.py 25.49% <35.29%> (+5.49%) :arrow_up:
protopipe/scripts/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f0d73e6...db8d430. Read the comment docs.