cta-observatory / protopipe

Prototype data analysis pipeline for the Cherenkov Telescope Array Observatory
https://protopipe.readthedocs.io/en/latest/
Other
5 stars 13 forks source link

Improve models generation #96

Closed HealthyPear closed 3 years ago

HealthyPear commented 3 years ago

Requirements

Summary of expected modifications

review-notebook-app[bot] commented 3 years ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

codecov[bot] commented 3 years ago

Codecov Report

Merging #96 (d10dac3) into master (166fbe0) will increase coverage by 0.00%. The diff coverage is 77.77%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   48.92%   48.93%           
=======================================
  Files          22       23    +1     
  Lines        2001     2058   +57     
=======================================
+ Hits          979     1007   +28     
- Misses       1022     1051   +29     
Impacted Files Coverage Δ
protopipe/scripts/write_dl2.py 4.91% <3.84%> (+<0.01%) :arrow_up:
protopipe/scripts/build_model.py 86.32% <86.30%> (-0.29%) :arrow_down:
protopipe/mva/utils.py 30.65% <87.50%> (+0.22%) :arrow_up:
protopipe/mva/__init__.py 100.00% <100.00%> (ø)
protopipe/mva/io.py 100.00% <100.00%> (ø)
protopipe/mva/train_model.py 64.00% <100.00%> (-24.24%) :arrow_down:
protopipe/scripts/data_training.py 94.87% <100.00%> (+0.27%) :arrow_up:
protopipe/scripts/tests/test_pipeline.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 166fbe0...d10dac3. Read the comment docs.