search

cta-observatory / pycorsikaio

Python reader for CORSIKA binary file format
MIT License
9 stars 2 forks source link

Use setuptools_scm, move options to setup.cfg #17

Closed maxnoe closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 97.18% // Head: 95.69% // Decreases project coverage by -1.48% :warning:

Coverage data is based on head (5862314) compared to base (e28d85e). Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #17 +/- ## ========================================== - Coverage 97.18% 95.69% -1.49% ========================================== Files 17 19 +2 Lines 355 372 +17 ========================================== + Hits 345 356 +11 - Misses 10 16 +6 ``` | [Impacted Files](https://codecov.io/gh/cta-observatory/pycorsikaio/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [corsikaio/version.py](https://codecov.io/gh/cta-observatory/pycorsikaio/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y29yc2lrYWlvL3ZlcnNpb24ucHk=) | `58.33% <58.33%> (ø)` | | | [corsikaio/\_dev\_version/\_\_init\_\_.py](https://codecov.io/gh/cta-observatory/pycorsikaio/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y29yc2lrYWlvL19kZXZfdmVyc2lvbi9fX2luaXRfXy5weQ==) | `80.00% <80.00%> (ø)` | | | [corsikaio/\_\_init\_\_.py](https://codecov.io/gh/cta-observatory/pycorsikaio/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-Y29yc2lrYWlvL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

maxnoe commented 2 years ago

Hi, yes, i don't think there can be a meaningful unit test for those lines related to not being able to import setuptools_scm for example