search

cta-observatory / pycorsikaio

Python reader for CORSIKA binary file format
MIT License
9 stars 2 forks source link

Fix runheader pos #4

Closed maxnoe closed 5 years ago

maxnoe commented 5 years ago

There was an error in the CORSIKA docs regarding the position of the number of showers.

According to the docs, it was position 94, but it is written to position 93 (start counting at 1).

Heck and Pierog decided to leave as is and update the docs. These are the changes reflecting that.

Mail from T. Pierog:

Thanks a lot for this notification. You are completely right. We will correct this in the next release (not sure whether it is better to keep it at position 93 as it was before and to keep compatibility or to really move it to have more space for something which will never be used probably).

Mail by me:

I would personally lean towards leaving it at is and just update the documentation of all affected versions (also 7.69, ...).

This would make it easier for everybody reading corsika files (e.g. simtel array, pycorsikaio, etc.).

Mail by D. Heck

this I have now performed, i.e. the place 93 of the RUNH block contains the NSHOW quantity in the program and in the documentation.