search

cta-observatory / pyeventio

Python read-only implementation for the EventIO data format used by the CORSIKA 7 IACT extension and sim_telarray
MIT License
10 stars 12 forks source link

Implement PixelList v1, ImageParameters v6, read LaserCalibration n_pixels as unsigned #267

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub.

I am waiting for a suitable file from @lheckmann, the original file she used for the report is a bit too large to use as a test file and since it only triggers with more than 37k pixels, I wasn't yet trying myself to create one.

lheckmann commented 1 year ago

Hi Max, you forgot to commit also the new test files, so the tests fail on GitHub.

I am waiting for a suitable file from @lheckmann, the original file she used for the report is a bit too large to use as a test file and since it only triggers with more than 37k pixels, I wasn't yet trying myself to create one.

I sent you one on slack that should hopefully work. Here it is as well, let me know if it works: hess_raw.simtel.gz

maxnoe commented 1 year ago

@orelgueta File added and tests adapted

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (074ef89) 86.46% compared to head (7e72b61) 86.54%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #267 +/- ## ========================================== + Coverage 86.46% 86.54% +0.07% ========================================== Files 24 24 Lines 2201 2214 +13 ========================================== + Hits 1903 1916 +13 Misses 298 298 ``` | [Files](https://app.codecov.io/gh/cta-observatory/pyeventio/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [src/eventio/simtel/objects.py](https://app.codecov.io/gh/cta-observatory/pyeventio/pull/267?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-c3JjL2V2ZW50aW8vc2ltdGVsL29iamVjdHMucHk=) | `81.45% <100.00%> (+0.24%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.