search

cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Add fixture containing some prod5 irfs from zenodo #211

Closed RuneDominik closed 1 year ago

RuneDominik commented 1 year ago

This intends to add a fixture for future unit-testing containing some of the prod5 irfs published on zenodo. Since downloading the files each time a new github action is triggered is time-consuming we try to cache things using github's action/cache.

ATM this PR is intended to do some live-testing with github's CI. I undraft it once everything works. Edit: Everything should be working now

codecov[bot] commented 1 year ago

Codecov Report

Base: 91.05% // Head: 91.08% // Increases project coverage by +0.03% :tada:

Coverage data is based on head (2c51a34) compared to base (0c3abf6). Patch coverage: 94.11% of modified lines in pull request are covered.

:exclamation: Current head 2c51a34 differs from pull request most recent head 20afc01. Consider uploading reports for the commit 20afc01 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ========================================== + Coverage 91.05% 91.08% +0.03% ========================================== Files 41 43 +2 Lines 1699 1716 +17 ========================================== + Hits 1547 1563 +16 - Misses 152 153 +1 ``` | [Impacted Files](https://codecov.io/gh/cta-observatory/pyirf/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [pyirf/conftest.py](https://codecov.io/gh/cta-observatory/pyirf/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvY29uZnRlc3QucHk=) | `92.85% <92.85%> (ø)` | | | [pyirf/tests/test\_resources.py](https://codecov.io/gh/cta-observatory/pyirf/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvdGVzdHMvdGVzdF9yZXNvdXJjZXMucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

maxnoe commented 1 year ago

These files should also be added to gitignore or stored in a place outside the repo