search

cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Use prod5 irf fixture in AEFF interpolation test #214

Closed RuneDominik closed 1 year ago

RuneDominik commented 1 year ago

This PR changes the test for the aeff interpolation to use actual irfs instead of a dummy effective area.

maxnoe commented 1 year ago

I actually like the test with specific, artificially created test data better checking a specific result better. This is a much more stringent test than what you have now on the prod5b IRFs.

RuneDominik commented 1 year ago

Keep both to assert it works on "real" data and give a more understandable test to future developers? While stringent, the old test is also unintuitive in its data creation and therefor not easy verifiable.