search

cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Update .github workflows #242

Closed RuneDominik closed 1 year ago

RuneDominik commented 1 year ago

This updates the workflows to the newest version and adds a test setup for python 3.11.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (642940a) 94.33% compared to head (05a5274) 94.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #242 +/- ## ======================================= Coverage 94.33% 94.33% ======================================= Files 58 58 Lines 2738 2738 ======================================= Hits 2583 2583 Misses 155 155 ``` | [Impacted Files](https://app.codecov.io/gh/cta-observatory/pyirf/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [.../interpolation/tests/test\_griddata\_interpolator.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi90ZXN0cy90ZXN0X2dyaWRkYXRhX2ludGVycG9sYXRvci5weQ==) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

maxnoe commented 1 year ago

Thanks!

As per NEP-29, we can also drop 3.8 now:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

RuneDominik commented 1 year ago

Thanks!

As per NEP-29, we can also drop 3.8 now:

On Apr 14, 2023 drop support for Python 3.8 (initially released on Oct 14, 2019)

If we want this I'll make this a new PR, arguably we could wait for ctapipe to make this move as pyirf likely will become a dependency there sometime and we may want to aim for consistency throughout cta-observatory packages. However, even them requiring python >= 3.8 and us python >= 3.9 is ofc. solvable.

maxnoe commented 1 year ago

The PR for this in ctapipe is already open. But that's kind of besides the point. The consistency here is via NEP 29, as soon as we make a new non-bugfix release, we drop versions accordingly.