Closed maxnoe closed 1 year ago
Patch coverage: 99.35%
and project coverage change: +0.05%
:tada:
Comparison is base (
19fff68
) 94.73% compared to head (1164644
) 94.78%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yes, it does. At the moment MomentMoprhInterpolator
, QuantileInterpolator
and MomentMorphNearestSimplexExtrapolator
also norm to a sum of one. As this however only is a global factor, we could just nomalize by integration in EnergyDispersionEstimator
after computing the interpolant, right?
Edit: There are probably more things that need to be changed. E.g. adding some factors to mean_std_estimation
I'm however not sure how this effects the performance of the algorithms. All EDisps I've used so far for testing summed to one as they were computed with pyirf.
@RuneDominik done
@RuneDominik does this have also implications on the interpolation code?