cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Start working on fixing interpolation for fixed edisp #251

Closed maxnoe closed 1 year ago

maxnoe commented 1 year ago

@RuneDominik This is a PR targeting #250 with changes related to the interpolation code.

I started this during ICRC and will have a look now again, I don't remember quite how far I got, please have a look and maybe just push here any changes you might want to include to make it work

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 99.31% and project coverage change: +0.02% :tada:

Comparison is base (8275a43) 94.74% compared to head (f4a929c) 94.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## fix_edisp_normalization #251 +/- ## =========================================================== + Coverage 94.74% 94.76% +0.02% =========================================================== Files 60 60 Lines 2985 3040 +55 =========================================================== + Hits 2828 2881 +53 - Misses 157 159 +2 ``` | [Files Changed](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | Coverage Δ | | |---|---|---| | [pyirf/interpolation/component\_estimators.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9jb21wb25lbnRfZXN0aW1hdG9ycy5weQ==) | `99.27% <92.85%> (-0.73%)` | :arrow_down: | | [pyirf/interpolation/base\_interpolators.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9iYXNlX2ludGVycG9sYXRvcnMucHk=) | `95.00% <94.11%> (-1.30%)` | :arrow_down: | | [pyirf/interpolation/base\_extrapolators.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9iYXNlX2V4dHJhcG9sYXRvcnMucHk=) | `100.00% <100.00%> (ø)` | | | [pyirf/interpolation/moment\_morph\_interpolator.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9tb21lbnRfbW9ycGhfaW50ZXJwb2xhdG9yLnB5) | `100.00% <100.00%> (ø)` | | | [pyirf/interpolation/nearest\_neighbor\_searcher.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9uZWFyZXN0X25laWdoYm9yX3NlYXJjaGVyLnB5) | `100.00% <100.00%> (ø)` | | | [...yirf/interpolation/nearest\_simplex\_extrapolator.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9uZWFyZXN0X3NpbXBsZXhfZXh0cmFwb2xhdG9yLnB5) | `100.00% <100.00%> (ø)` | | | [pyirf/interpolation/quantile\_interpolator.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi9xdWFudGlsZV9pbnRlcnBvbGF0b3IucHk=) | `98.21% <100.00%> (+0.06%)` | :arrow_up: | | [...irf/interpolation/tests/test\_base\_extrapolators.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi90ZXN0cy90ZXN0X2Jhc2VfZXh0cmFwb2xhdG9ycy5weQ==) | `100.00% <100.00%> (ø)` | | | [...irf/interpolation/tests/test\_base\_interpolators.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi90ZXN0cy90ZXN0X2Jhc2VfaW50ZXJwb2xhdG9ycy5weQ==) | `100.00% <100.00%> (ø)` | | | [...ion/tests/test\_component\_estimator\_base\_classes.py](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory#diff-cHlpcmYvaW50ZXJwb2xhdGlvbi90ZXN0cy90ZXN0X2NvbXBvbmVudF9lc3RpbWF0b3JfYmFzZV9jbGFzc2VzLnB5) | `96.69% <100.00%> (+0.16%)` | :arrow_up: | | ... and [5 more](https://app.codecov.io/gh/cta-observatory/pyirf/pull/251?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cta-observatory) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maxnoe commented 1 year ago

Going on in #250