search

cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Ignore warnings of possibly NaN bins in sensitivity #264

Closed Tobychev closed 11 months ago

Tobychev commented 11 months ago

By putting the multiplications with rel_sens into a errstate context manager that ignores warnings from the invalid floating point operations the NaNs in rel_sens cause.

codecov[bot] commented 11 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (main@d8de7a4). Click here to learn what that means.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ======================================= Coverage ? 95.35% ======================================= Files ? 60 Lines ? 3097 Branches ? 0 ======================================= Hits ? 2953 Misses ? 144 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Tobychev commented 11 months ago

@maxnoe I have no idea why, but I think something has broken the doctests.

maxnoe commented 11 months ago

Seems to just be a download failure, I restarted the docs build

Tobychev commented 11 months ago

The problem seems to be pretty enduring.

maxnoe commented 11 months ago

Should be fixed now... let's try again