Open luca-dib opened 7 months ago
Attention: Patch coverage is 30.00000%
with 21 lines
in your changes are missing coverage. Please review.
Project coverage is 95.01%. Comparing base (
c7db045
) to head (34ecab9
). Report is 9 commits behind head on main.:exclamation: Current head 34ecab9 differs from pull request most recent head af76243
Please upload reports for the commit af76243 to get more accurate results.
Files | Patch % | Lines |
---|---|---|
pyirf/simulations.py | 31.25% | 11 Missing :warning: |
pyirf/irf/effective_area.py | 20.00% | 8 Missing :warning: |
pyirf/utils.py | 50.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Adds two methods of calculating the effective area in bins of energy and two spacial dimensions. These methods differ in the coordinate frame used for the spacial dimensions.
calculate_effective_area_3d_polar
uses a polar coordinate system with FOV pointing position offset and position angle coordinatescalculate_effective_area_3d_nominal
uses a quasi-cartesian coordinate system with FOV longitude and latitude coordinates centred on the pointing positionAlso adds respective functions to calculate the number of showers expected in the 3D bins from simulation info to the SimulatedEventsInfo class (
calculate_n_showers_3d_polar
,calculate_n_showers_3d_nominal
), as well as a utility function to calculate the position angle w.r.t. the pointing from an event table (calculate_source_fov_position_angle
).