cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Effective Area 3D #281

Open luca-dib opened 7 months ago

luca-dib commented 7 months ago

Adds two methods of calculating the effective area in bins of energy and two spacial dimensions. These methods differ in the coordinate frame used for the spacial dimensions.

Also adds respective functions to calculate the number of showers expected in the 3D bins from simulation info to the SimulatedEventsInfo class (calculate_n_showers_3d_polar, calculate_n_showers_3d_nominal), as well as a utility function to calculate the position angle w.r.t. the pointing from an event table (calculate_source_fov_position_angle).

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 30.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 95.01%. Comparing base (c7db045) to head (34ecab9). Report is 9 commits behind head on main.

:exclamation: Current head 34ecab9 differs from pull request most recent head af76243

Please upload reports for the commit af76243 to get more accurate results.

Files Patch % Lines
pyirf/simulations.py 31.25% 11 Missing :warning:
pyirf/irf/effective_area.py 20.00% 8 Missing :warning:
pyirf/utils.py 50.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #281 +/- ## ========================================== - Coverage 95.60% 95.01% -0.60% ========================================== Files 62 62 Lines 3278 3308 +30 ========================================== + Hits 3134 3143 +9 - Misses 144 165 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.