cta-observatory / pyirf

Python IRF builder
https://pyirf.readthedocs.io/en/stable/
MIT License
15 stars 25 forks source link

Improve Handling of Fill-Values in RAD_MAX Estimator #282

Closed RuneDominik closed 4 months ago

RuneDominik commented 5 months ago

In the current version, the RAD_MAX estimator does not handle fill-values and thus produces results that inter-/extrapolate between actual values and fill-values, yielding results that do not resemble the expected behavior in edge-cases (e.g. RAD_MAX values sharply rising after some energy, see Fig. below). This PR introduces some form of combinatoric edge-case handling in 1 and 2D grids.

rad_max_cuts_new.pdf

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.74%. Comparing base (cb92eef) to head (b6b33c9). Report is 2 commits behind head on main.

:exclamation: Current head b6b33c9 differs from pull request most recent head 26a9d8b. Consider uploading reports for the commit 26a9d8b to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #282 +/- ## ========================================== + Coverage 95.60% 95.74% +0.13% ========================================== Files 62 62 Lines 3278 3381 +103 ========================================== + Hits 3134 3237 +103 Misses 144 144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.