cta-wave / WMAS

Test suite for the Web Media API Snapshot Specification
Other
18 stars 9 forks source link

test runner / deployment: HbbTV / Smart TV friendly landing page #61

Closed jpiesing closed 2 years ago

jpiesing commented 3 years ago

The landing page used in WMAS (and re-used in DPCTF) is not very HbbTV friendly and probably not very friendly towards Smart TVs in general.

It would be good to have a more Smart TV / HbbTV friendly landing page.

It may be more appropriate to have two pages;

jpiesing commented 3 years ago

This issue may turn into nothing if the test engineer would never need to interact with this page on a device under test - only read the first 8 characters of the token. For #62 , there needs to be some HbbTV specific API calls made, they can be in an HbbTV-specific landing page, in a SmartTV landing page after testing if it's running on HbbTV or in an intermediate page which then runs the generic landing page.

louaybassbouss commented 2 years ago

@jpiesing the landing page now includes a javascript lib (hbbtv.js) which checks via the User Agent if the test runs on HbbTV terminal and if yes, it do the additional initialisations required for HbbTV.

JohnRiv commented 2 years ago

HATF March 2nd update - @louaybassbouss will provide a screencast of the test set up

yanj-github commented 2 years ago

@louaybassbouss and @jpiesing correct me please if I am wrong.

On the TR individual test always starts with pre-test.html (only for dpctf tests not applicable for WMAS) before it goest to actual test HTML+JS. pre-test.html shows QR code that is used by OF to scan and determine the start of test and also which test is running. If HbbTV specific API calls made and broadcast to start test I guess it needs to show pre-test page to make a start. Do we need to to make the pre-test page HbbTV / Smart TV friendly so that the TV can lands on this page?

yanj-github commented 2 years ago

@louaybassbouss I think we would like to have a javascript lib (hbbtv.js) included for all the pages that the Device Under Test needs to serve as part of running the WMAS tests and DPCTF tests please? HTML pages that should be on companion device are not required.

FritzHeiden commented 2 years ago

@yanj-github hbbtv.js is now included in all HTML files.

yanj-github commented 2 years ago

Thank you very much @FritzHeiden I can see changes for DPCTF test on master branch. Can you kindly point me where you updated for WAMS tests please? I am using http://webapitests2019.ctawave.org:8000/ I can not see the change.

louaybassbouss commented 2 years ago

Thank you very much @FritzHeiden I can see changes for DPCTF test on master branch. Can you kindly point me where you updated for WAMS tests please? I am using http://webapitests2019.ctawave.org:8000/ I can not see the change.

WMAS Tests are forked from WPT Project without modifications it is difficult to include hbbtv.js in thousands of files. This is why hbbtv.js is only included on the Landing Page (https://webapitests2019.ctawave.org/wave/index.html). In out test, HbbTV initialisation on the landing page was sufficient. Are you facing issues? if yes can you share details.

yanj-github commented 2 years ago

@louaybassbouss Yes indeed, I understand this involve in changing thousands of files. The issue I have is, I am creating a test session and start a test via API calls, and trying to broahcast DUT to land on a page to run the test session. This will be a first test url which cannot launched from HbbTV broadcast signalling without having hbbtv.js.

Is it eaiser to have a HbbTV-specific landing page (already bind the session tocken) instead of standard index.html? Something like "https://webapitests2019.ctawave.org/wave/index.html?token=xxxxxxx" I also noticed "https://webapitests2019.ctawave.org/wave/newsession.html?token=xxxxxxx" Which we might be able to use, But if I start test elsewhere (not on DUT) newsession.html not direct to correct test url.

FritzHeiden commented 2 years ago

@yanj-github You can use /wave/next.html?token=xxxx to execute the next test in the session. However, hbbtv.js is still required to be added to next.html

yanj-github commented 2 years ago

Thanks @FritzHeiden That might be a approach. Will time delay between start test and /wave/next.html?token=xxxx cause any missed tests run at the begining?

FritzHeiden commented 2 years ago

Start test will set some session properties and invoke appropriate events. The test runner registers running and completed tests upon actually requesting a test to execute. This happens on the landing page, in test files when they are finished, as well as in next.html, so there should be no tests missing due to any delays.

yanj-github commented 2 years ago

Thanks @FritzHeiden I just checked the DPCTF tests, by landing on /wave/next.html?token=xxxx which works fine. Can you help to add hbbtv.js to next.html for WMAS tests please?

FritzHeiden commented 2 years ago

@yanj-github I added the hbbtv.js to next.html and added another query parameter "delay", which will delay the test execution by the provided value in ms. This may help if the redirection to the test is faster than hbbtv takes to initialize.

yanj-github commented 2 years ago

@FritzHeiden Can you provide information of where I can set this "delay" please? Currently next.html redirected so quicky so that DUT cannot land on this page.

louaybassbouss commented 2 years ago

@FritzHeiden Can you provide information of where I can set this "delay" please? Currently next.html redirected so quicky so that DUT cannot land on this page.

@yanj-github this is an example https://webapitests2019.ctawave.org/wave/index.html?token=xxxxxxx&delay=3000 . This will delay the redirection for 3s.

yanj-github commented 2 years ago

Thanks @louaybassbouss I just tried with one test this is working fine.

JohnRiv commented 2 years ago

@jpiesing let us know if you would like to see anything further or if this can be closed

jpiesing commented 2 years ago

Based on @yanj-github 's comment above, I'm OK to close this.