cta-wave / dpctf-deploy

Repo for Docker deployment. This is basically the repository you need to deploy the Test Runner (and later the Test Execution Framework) locally. It will make the deployment and configuration of all components much easier
Other
2 stars 5 forks source link

Adding custom tests #66

Closed yanj-github closed 4 months ago

yanj-github commented 4 months ago

I think from docker-compose.yml the line - ./tests:/home/ubuntu/tests is incorrect it should be - ./tests:/home/ubuntu/DPCTF/tests? Or maybe better to remove this line and add correct instruction in https://github.com/cta-wave/dpctf-deploy/tree/master?tab=readme-ov-file#adding-custom-tests I think, to get this correct, "tests/new-test-group/new-custom-test.html" the "docker-compose.yml" file should has the line - ./tests/new-test-group:/home/ubuntu/DPCTF/new-test-group

FritzHeiden commented 4 months ago

This is actually correct. When starting the container, all files in that directory will be linked to the correct location, so you don't have to deal with the docker-compose.yml when adding custom tests. All you need to do is place them in the tests directory.

yanj-github commented 4 months ago

Thanks @FritzHeiden But I cannot get it working without changing "- ./tests:/home/ubuntu/tests" to "- ./tests:/home/ubuntu/DPCTF/tests". The new tests not visible from the configuration page.

FritzHeiden commented 4 months ago

Thanks @yanj-github Will check

FritzHeiden commented 4 months ago

I am unable to reproduce this issue. The following works for me:

  1. create a directory test-group inside the tests directory
  2. copy some test file into the new test-group directory, e.g. sequential-track-playback__t1.html: dpctf-deploy/tests/test-group/sequential-track-playback__t1.html
  3. run docker-compose up
  4. when configuring a new test session I can see test-group containing one test: image
yanj-github commented 4 months ago

Thank you very much, @FritzHeiden I have got it working now. The reason it was not working before is that I have got same folder name for new tests that added to the tests directory. Changed ./cfhd_15_30_60-local to ./cfhd_15_30_60-local-new worked now.

yanj-github commented 4 months ago

This is working, test group folder name added to tests folder shall not be same as existing test. Close this issue.