search

cta-wave / dpctf-deploy

Repo for Docker deployment. This is basically the repository you need to deploy the Test Runner (and later the Test Execution Framework) locally. It will make the deployment and configuration of all components much easier
Other
2 stars 5 forks source link

Clone repository for Observation Framework #99

Open gitwjr opened 3 weeks ago

gitwjr commented 3 weeks ago

@louaybassbouss @yanj-github It appears the Deploy readme has the wrong link for cloning the device-observation-framework repository. Clone repository Using the git command line tool, you can download the current version of the dpctf-deploy repository to your system:

Linux / macOS / WSL2:

git clone https://github.com/cta-wave/dpctf-deploy

Shouldn't it be git clone https://github.com/cta-wave/device-observation-framework ? I tried git clone https://github.com/cta-wave/dpctf-deploy and it just made another copy of the TR within dpctf-deploy and no observation framework folder was created. When I changed it to ...cta-wave/devoce-observation-framework it created the folder and its contents.

Am I correct?

yanj-github commented 3 weeks ago

I think this is correct as ./build-dof.sh or .\build-dof.bat will clone the https://github.com/cta-wave/device-observation-framework.git. If you already cloned https://github.com/cta-wave/dpctf-deploy before and wants to set up OF same PC/sever just need to skip the cloning step.

gitwjr commented 3 weeks ago

After building (and docker-compose up) the TR, the device-observation=framework folder (and its contents) did not show up in DPCTF-Deploy folder. It was not until I cloned the Device OF and built it that it appeared and I could run build-dof.sh.

gitwjr commented 1 week ago

After discussions with Louay and Fritz it appears that there is no need to re-clone the repository as stated in Phase 3 of the Docker README instructions if you have already cloned and built the TR repository in Phase 2. The necessary files are already included in dpctf-deploy folder to run docker-compose up and when cloning it states the directory is not empty. This should be made clear in the instructions.