search

cta-wave / dpctf-test-runner

Repo for the DPCTF Test Runner
Other
0 stars 3 forks source link

wrong link in DPCTF results page #16

Closed jpiesing closed 2 years ago

jpiesing commented 2 years ago

If you look this screen dump of a DPCTF results page, you will see the link to github.com is to WMAS2017 which is wrong. There may be other things wrong about it too.

image

louaybassbouss commented 2 years ago

Thanks @jpiesing we will check and fix it. The links should point to the tests in the generated folder.

FritzHeiden commented 2 years ago

This is fixed now. As this is part of the Dockerfile script, please recreate the docker image from scratch.

louaybassbouss commented 2 years ago

@jpiesing please check and close if the issue if fixed on your side.

jpiesing commented 2 years ago

This is fixed now. As this is part of the Dockerfile script, please recreate the docker image from scratch.

Sorry but this isn't fixed. I believe I have recreated the docker image from scratch - docker-compose. Unless of course you mean actually deleting the docker image.

image

FritzHeiden commented 2 years ago

Using the ./build.sh script with --reload-runner isn't sufficient, as the tool that creates these reports is separate from the test runner and installed before the runner. So yes, you would need to delete the whole image to make sure the step of installing the wptreport tool is actually executed and not loaded from cache.

jpiesing commented 2 years ago

@FritzHeiden To be clear, do you mean docker rm dpctf or docker rmi dpctf or something else?

FritzHeiden commented 2 years ago

docker rmi dpctf. To be sure, all dpctf related images have to be removed

jpiesing commented 2 years ago

Fix confirmed.