search

cta-wave / dpctf-test-runner

Repo for the DPCTF Test Runner
Other
0 stars 3 forks source link

add simple modal EULA with local cookie #29

Closed rbouqueau closed 1 year ago

rbouqueau commented 1 year ago

See https://github.com/cta-wave/dpctf-deploy/issues/32

louaybassbouss commented 1 year ago

@rbouqueau thanks for your PR. but the landing page will be displayed on DUT like TV. Did you tested your changes on a TV device? How the user can accept/reject the EULA on a TV device? I think this should happen during the deployment and not on the DUT. @FritzHeiden prepared this PR https://github.com/cta-wave/dpctf-deploy/pull/36. wdyt?

rbouqueau commented 1 year ago

I think we should integrate Fritz's PR if it is more suited than mine. Not tested on a TV, just on a Desktop Web browser.

I proposed myself for this AP at the last meeting because I was already taking care of the one at https://cta-wave.github.io/Test-Content/.

Please don't hesitate to close this PR.

mbergman42 commented 1 year ago

I agree, from CTA's perspective this is a Deploy EULA (install time), not runtime.

FritzHeiden commented 1 year ago

Closing this, as the other PR got merged.