cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

Splicing tests not yet defined #101

Closed rcottingham closed 1 year ago

rcottingham commented 1 year ago

Splicing tests have not been defined. These are specified in §8.8, §8.13 and §8.14 in the Device Playback Capabilities Specification.

It has therefore not been possible to verify the OF logic for these tests.

For further details on the issue please see: “Eurofins CTA WAVE Test Suite validation of the Observation Framework results including analysis 31 Jan 2023.xls”

jpiesing commented 1 year ago

I'm a little confused at the problem description here. Is this saying that the splicing tests were left out of the .csv file that is used to combine template HTML+JS and test content into an actual test case?

rcottingham commented 1 year ago

Hi Jon - splicing tests results have not yet been provided by Fraunhofer, so we believe they are not ready.

There is some test splicing content in the avc_sets folder, but not in the required CMAF media profiles. (Also, the content in the avc_sets appears to be general playback and not splicing).

As soon as we get confirmation from Fraunhofer that the splicing tests have passed, we will run them in the Observation Framework.

I hope that clarifies and apologies to all for any confusion.

FritzHeiden commented 1 year ago

As far as I understand, the provided test results are supposed to help to validate the new test content (2022-10-17). Splicing content was not included in this content update, so the corresponding tests were not included.

jpiesing commented 1 year ago

@FritzHeiden @rbouqueau says in https://github.com/cta-wave/Test-Content/issues/19 that splicing content was created in October 2022. Please can you find this content, update the .csv, generate the splicing tests with this October 2022 content and see if it works as far as you can test.

rbouqueau commented 1 year ago

I plan to update the streams and database.json today. Let me update you here when it's done (so that people work on the latest version of the content).

rbouqueau commented 1 year ago

That's updated.

FritzHeiden commented 1 year ago

I am unable to access the new splice content either online mpd or zip download.

rbouqueau commented 1 year ago

Indeed I had not updated everything. Could you please retry?

FritzHeiden commented 1 year ago

Tested splice current splice content (2023-04-28) and it works fine. Tests are still on separate branch (content-2023-04-28) and will be merged to master once all other tests work fine with the new content.

FritzHeiden commented 1 year ago

Spliced tests are now merged to master

jpiesing commented 1 year ago

@rcottingham Above you said that ..

As soon as we get confirmation from Fraunhofer that the splicing tests have passed, we will run them in the Observation Framework.

The above comments from Fritz suggest this is now the case. Do you need anything more from them?

gitwjr commented 1 year ago

@FritzHeiden to provide recordings to @rcottingham

FritzHeiden commented 1 year ago

@rcottingham recordings can be found here: https://drive.google.com/file/d/1_M_G-5rbiVnS6QQYcCUUEcggJ5reH_Ud/view?usp=sharing

DannyKokkinos commented 1 year ago

Hey @FritzHeiden could you please approve my request to access the recordings from the google drive.

FritzHeiden commented 1 year ago

@DannyKokkinos I updated access permissions for the link. Please try again

rcottingham commented 1 year ago

Splicing test ok. Limitation with current Master branch of Observation Framework with calculating the duration of the content with variable fragment durations. Issue fixed in DPCAT22 branch to be merged once development/testing complete. See issue https://github.com/cta-wave/device-observation-framework/issues/46