search

cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

timescale is missing from representations level #109

Closed yanj-github closed 1 year ago

yanj-github commented 1 year ago

for test code "ba9a668f3c43b6829919d9c51cbe1b3c" in https://github.com/cta-wave/dpctf-tests/blob/dpcat-2022-10-17/generated/tests.json representation 6 has "segmentTimeline" but "timescale" is missing.

FritzHeiden commented 1 year ago

The dpcat-2022-10-17 branch is outdated. The current tests.json on master branch has timescale parameter for "ba9a668f3c43b6829919d9c51cbe1b3c" https://github.com/cta-wave/dpctf-tests/blob/master/generated/tests.json

yanj-github commented 1 year ago

Thanks @FritzHeiden we will point to master branch instead. However I am still see "timescale" is missing on representation level. image "segmentTimeline" presented on representation level and "timescale" should be presented as well. Hope this is clear now. Feel free to let me know if you have further questions.

gitwjr commented 1 year ago

@FritzHeiden please fix.

gitwjr commented 1 year ago

@FritzHeiden @louaybassbouss Louay to check with Fritz if this is done.

FritzHeiden commented 1 year ago

I tried to check whether this issue still exists, however, it seems things have change to the extend that I feel I can't. The mentioned test Id doesn't exist anymore. For any example MPD I look into, the timescale parameter is present. @yanj-github Maybe you could check if timescale parameters are present everywhere you expect them to be, otherwise please hint me to the exact location so I can fix it.

yanj-github commented 1 year ago

@FritzHeiden can you check on master branch for test cfhd_14.985_29.97_59.94-online/switching-set-playback__ss1-1.html last three representations. e.g: "../../../../chdf_sets/14.985_29.97_59.94/t20/2023-04-28/1": { "period": 1, "duration": 59, "type": "video", "frame_rate": "60/1001", "fragment_duration": 2.002, "segmentTimeline": [ { "r": 28, "t": 0, "d": 120120 }, { "d": 116116 } ] }, It seems that every representations has different segmentTimeline then the base one so additional segmentTimeline is defined in representations level but correspondent timescale is missing.

FritzHeiden commented 1 year ago

Thank you for the details. I pushed a fix to master. Please check if there are any issues remaining with the tests.json parameters

gitwjr commented 1 year ago

@yanj-github Please check if any remaining issues.