cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

creation of aac audio tests #111

Closed jpiesing closed 4 months ago

jpiesing commented 1 year ago

This issue is for the creation of the HTML+JS code for the AAC audio tests - referencing the new AAC test content as follows;

http://dash-large-files.akamaized.net/WAVE/vectors/releases/1/

e.g. http://dash-large-files.akamaized.net/WAVE/vectors/releases/1/caaa_sets/aac_lc/at8/2023-04-27/stream.mpd

@yanj-github @rcottingham Please can you help @FritzHeiden with any additional information he needs.

FritzHeiden commented 1 year ago

I would need some matrix matching audio content with test template to generate the audio tests from

rcottingham commented 1 year ago

Matrix attached CTA WAVE_AAC Matix_20230428.xlsx. Note:

Note, Resillion are responsible to generate audio tests for 8.2-8.14 (excluding 8.5 as out of scope). Fraunhofer to generate Section 9 tests.

DannyKokkinos commented 1 year ago

Pull request for the aac tests has been made: https://github.com/cta-wave/dpctf-tests/pull/112 @FritzHeiden @louaybassbouss

FritzHeiden commented 1 year ago

Tests are generated in the temporary feature branch, which will be merged once all tests properly work with the new content https://github.com/cta-wave/dpctf-tests/commits/content-2023-04-28

yanj-github commented 1 year ago

@FritzHeiden Thanks for getting this done. Just a quick comment on those section 9 tests:

I think, we need to add the audio to exsiting video test not create a new test. For example: "regular-playback-of-a-cmaf-presentation","https://dash.akamaized.net/WAVE/vectors/cfhd_sets/15_30_60/t1/2023-04-28/stream.mpd","https://dash.akamaized.net/WAVE/vectors/releases/1/caac_sets/aac_lc/at1/2023-04-27/stream.mpd","cfhd_15_30_60-online"

And remove: "regular-playback-of-a-cmaf-presentation","","https://dash.akamaized.net/WAVE/vectors/releases/1/caac_sets/aac_lc/at1/2023-04-27/stream.mpd","caac_sets-online"

yanj-github commented 1 year ago

I think is it useful to link another issue to this one as they are related. https://github.com/cta-wave/Test-Content-Generation/issues/62

FritzHeiden commented 1 year ago

I think, we need to add the audio to exsiting video test not create a new test.

I updated the tests accordingly. In case of test 9.4, the audio and video segments are not in line, which is expected to cause issue with the audio

yanj-github commented 1 year ago

I updated the tests accordingly. In case of test 9.4, the audio and video segments are not in line, which is expected to cause issue with the audio

@FritzHeiden https://github.com/cta-wave/device-playback-task-force/issues/111 is still open for discussion. As far as I understand audio should match video playout. But correct me if I am wrong. Audio playback for 9.4 was not clearly defined on the spec.

FritzHeiden commented 1 year ago

The audio tests are now merged to master

yanj-github commented 1 year ago

@FritzHeiden will you be able to merge playback-over-wave-baseline-splice to have:

9.4 Splicing of WAVE Program with Baseline Constraints:

gitwjr commented 1 year ago

Relates to DPCTF Tests #110 . This is on @FritzHeiden list of tasks when checking splicing tests.
Also relates to https://github.com/cta-wave/Test-Content/issues/19

gitwjr commented 1 year ago

@FritzHeiden to provide recordings to @rcottingham

FritzHeiden commented 1 year ago

@FritzHeiden will you be able to merge playback-over-wave-baseline-splice to have:

9.4 Splicing of WAVE Program with Baseline Constraints:

* video: cfhd_sets/12.5_25_50/splice_main   cfhd_sets/12.5_25_50/splice_ad

* audio: caac_sets/aac_lc/at13   caac_sets/aac_lc/at14

This is now available in master

yanj-github commented 1 year ago

Thanks @FritzHeiden are these new audio tests and video audio combined tests been tested and validated on your end please?

FritzHeiden commented 1 year ago

Yes they are. I will provide a recording

FritzHeiden commented 1 year ago

@rcottingham recordings can be found here: https://drive.google.com/file/d/16U1A8A53zt-B532NOkZnOdX4lzOT6Spe/view?usp=sharing

rcottingham commented 1 year ago

Unfortunately, recording does not have audio so unable to run through Observation Framework

gitwjr commented 1 year ago

See also DPCTF-Tests Issue #110 unclear if audio not recorded or just missing.

gitwjr commented 11 months ago

Not in Launch.

FritzHeiden commented 10 months ago

@rcottingham recordings can be found here: https://drive.google.com/file/d/16U1A8A53zt-B532NOkZnOdX4lzOT6Spe/view?usp=sharing

Unfortunately, recording does not have audio so unable to run through Observation Framework

When I download the linked recordings there is audio present in the video. Could you specify what exactly is the problem?

yanj-github commented 7 months ago

@jpiesing can we close this issue as now we have aac audio tests generated, also Dolby audio is available.

jpiesing commented 4 months ago

@yanj-github I'm OK with closing this. Are you still confident there's nothing left to do under this issue?

yanj-github commented 4 months ago

@jpiesing yes please feel free to close this issue. we have issue with 9.4 but we have separate issue created for 9.4 test in general.

jpiesing commented 4 months ago

Closing as agreed.