search

cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

random-access-to-time: is it really testing what is required? #113

Closed jpiesing closed 11 months ago

jpiesing commented 1 year ago

From https://redmine.hbbtv.org/issues/12118 ...

The whole point of this test is to seek to a time that is not the start of a segment. Seeking to the start of a segment is covered by random-access-to-fragment.

Is is suggested that the value configured as the seek location "parameters.randomAccessTime", is in fact the start of a segment. That would make this test redundant and duplicative.

I can't find where this value is configured but please check the configured value and the segment length and confirm if there is a problem.

FritzHeiden commented 1 year ago

I have no access to the link you provided. The parameter is configured in a way that it fits the content we use in the DPCTF context. If other content with different segmentation is used, the parameter might need to be adjusted accordingly. This is what the test-config.json is for. More information on how to configure these parameters can be found in the documentation for test-config.json: https://github.com/cta-wave/dpctf-tests/blob/master/TEST_CONFIG.md

jpiesing commented 1 year ago

Looking in test-config.json, I see the following.

image

The WAVE test content has segment durations of 2s and 5s so 11s is not the start of a segment.

I will close this issue when the corresponding HbbTV issue is closed.

yanj-github commented 1 year ago

This issue has been addressed already https://github.com/cta-wave/dpctf-tests/issues/104

gitwjr commented 11 months ago

Closed. Addressed in #104 which was closed.