cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

eac3 tests are not working #130

Closed yanj-github closed 7 months ago

yanj-github commented 8 months ago

When running eac3 tests I have following error: promise_test: Unhandled rejection with value: object "Error: Unsupported MIME types or codecs: | audio/mp4; codecs="eac3"

I think it might be caused by the issue https://github.com/cta-wave/dpctf-test-runner/issues/32

However, ac4 tests are working fine.

louaybassbouss commented 8 months ago

@yanj-github the test reads the mimetype or codec string from the mpd and checks if the browser supports it using MediaSource.isTypeSupported(mimeType). If you check the MPDs of EAC3 and AC4 contents, you can see the mimeType and codec reported in each MPD as following:

Maybe the codec string of EAC3 content ist not correct? In this case, you need to fix it in the MPD and provide new content.

yanj-github commented 8 months ago

Thanks @louaybassbouss we will have a look.

yanj-github commented 8 months ago

@louaybassbouss Thanks for spotting it out, we confirm that this is contents issue. We will fix it and upload and regenerate tests.

yanj-github commented 7 months ago

@FritzHeiden and @louaybassbouss https://github.com/cta-wave/dpctf-deploy/pull/51 https://github.com/cta-wave/dpctf-tests/pull/131 Can you please review the pull request and merge when you happy with the changes please?

louaybassbouss commented 7 months ago

@yanj-github PR is merged

yanj-github commented 7 months ago

@FritzHeiden and @louaybassbouss can we get this merged as well please? Otherwise local test wont work with correct content. https://github.com/cta-wave/dpctf-deploy/pull/51