cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

report 'a: close' via QR code #173

Closed jpiesing closed 1 month ago

jpiesing commented 2 months ago

Here is an analysis of a failing test from the London test event.

image

a: reports values initialize, play, pause and representation_change

This test is failing because the last (red) frame is never shown.

This is very hard to analyse because there's no information available about whether/when/if MediaSource.endOfStream was called.

MediaSource.endOfStream not being called for any reason is IMHO the most likely reason for the last frame not being called.

Please consider modify the closeBuffer method to send 'a: close' (or a: endOfStream' if you prefer) so it's clear what is happening.

FritzHeiden commented 2 months ago

This is now implemented. QR code will show action 'close' when endOfStream is called. https://github.com/cta-wave/dpctf-tests/pull/174

louaybassbouss commented 1 month ago

@jpiesing can this be closed?

jpiesing commented 1 month ago

@jpiesing can this be closed?

Yes.