cta-wave / dpctf-tests

Repo for DPCTF Tests. We prefer to keep the Tests separated from Test Runner
Other
1 stars 5 forks source link

Design decisions / architecture documentation on tests & test runner #82

Closed louaybassbouss closed 1 year ago

louaybassbouss commented 2 years ago

Design decision of Test Runners and Tests already made

Lets use this issue to discuss these design decisions and if the there is a need to put them in a formal document (and keep it up-to-date in the future).

@jpiesing FYI

javierbarellano4v commented 2 years ago

@louaybassbouss First of all, thanks for posting these notes.

This posting is part of effort to confirm details on the inner workings of DPC test suite:

  1. Generally speaking if I need more details on Test Server and Test Harness Client I should consult W3C's documentation on WPT?

  2. Can we safely say that: a DPC test = Test Content + Instantiated HTML Template + JS ?

  3. An instantiated HTML template contains logic for a specific use case, e.g., out of order loading, sequential track playback, for Type 3 playback?

  4. Roughly speaking these interaction diagrams are still accurate?

       https://github.com/web-platform-tests/wpt/issues/16214

Just a couple to get started.... Thanks so much!

jpiesing commented 2 years ago

@louaybassbouss ?

This posting is part of effort to confirm details on the inner workings of DPC test suite:

1. Generally speaking if I need more details on Test Server and Test Harness Client I should consult W3C's documentation on WPT?

That is my understanding but @louaybassbouss needs to confirm.

2. Can we safely say that:   a DPC test = Test Content + Instantiated HTML Template + JS ?

Yes assuming what you mean by "Instantiated" is that the URLs for the Test Content are inserted in the original template.

3. An instantiated HTML template contains logic for a specific use case, e.g., out of order loading, sequential track playback, for Type 3 playback?

Yes-ish subject to previous comment re "instantiated'. This is all what's included in the original (un-instantiated?) template and copied over unmodified into what I think you are calling the "instantiated" template.

4. Roughly speaking these interaction diagrams are still accurate?
   ```
       https://github.com/web-platform-tests/wpt/issues/16214
   ```

@louaybassbouss ?

javierbarellano4v commented 2 years ago

Thanks @jpiesing

I need to redefine my 'instantiated template' as a HTML5 template populated or bound with URLs for Test Content.

And, 'un-instantiated' template or original template, is a HTML5 containing logic for specific use case, e.g., sequential track playback, for type 3 playback not bound to particular test content.

Think its more accurate, right?

louaybassbouss commented 2 years ago

Thanks @javierbarellano4v and @jpiesing sorry for delay I was on vacation I will reply in the next few hours to the comments, just landed in Vegas attending NAB.

louaybassbouss commented 2 years ago

This posting is part of effort to confirm details on the inner workings of DPC test suite:

1. Generally speaking if I need more details on Test Server and Test Harness Client I should consult W3C's documentation on WPT?

That is my understanding but @louaybassbouss needs to confirm.

I can confirm

2. Can we safely say that:   a DPC test = Test Content + Instantiated HTML Template + JS ?

Yes assuming what you mean by "Instantiated" is that the URLs for the Test Content are inserted in the original template.

agree with @jpiesing

3. An instantiated HTML template contains logic for a specific use case, e.g., out of order loading, sequential track playback, for Type 3 playback?

Yes-ish subject to previous comment re "instantiated'. This is all what's included in the original (un-instantiated?) template and copied over unmodified into what I think you are calling the "instantiated" template.

Yes the original un-instantiated template includes the test logic with placeholders for the URLs.

4. Roughly speaking these interaction diagrams are still accurate?
   https://github.com/web-platform-tests/wpt/issues/16214

Exactly the top one with "WPT Server (Python)" (attached below) and this is merged into WPT.

image

javierbarellano4v commented 2 years ago

@louaybassbouss Thanks, much appreciated! My apology for not replying sooner I was out of town on travel as well.

I may have additional questions later. I'm presenting DPCTF internally and thus all my questions.

Enjoy NAB in Vegas!

Thank you.

gitwjr commented 1 year ago

@javierbarellano4v - please confirm this is resolved. @FritzHeiden documented in the TR. If no further comments, we can close.

javierbarellano4v commented 1 year ago

This is resolved. Please close issue