Support embedding source files in Windows PDB

ctaggart / SourceLink

Source Code On Demand

MIT License

357 stars 55 forks source link

Support embedding source files in Windows PDB #297

Closed leonard-thieu closed 6 years ago

leonard-thieu commented 6 years ago

Roslyn compilers can support embedding source files in Windows PDBs starting in v2.6.0 (VS v15.5). Could support for this be added to SourceLink.Embed.AllSourceFiles?

leonard-thieu commented 6 years ago

Closing because I ended up with a solution sufficient for my needs.

jnm2 commented 6 years ago

@ctaggart Can we make this happen?

ctaggart commented 6 years ago

@jnm2 Go for it. Probably just drop of the condition: https://github.com/ctaggart/SourceLink/blob/master/SourceLink.Embed.AllSourceFiles/SourceLink.Embed.AllSourceFiles.targets#L3

jnm2 commented 6 years ago

What I didn't see was that an EmbedAllSources MSBuild property is in Roslyn master as of a couple weeks ago (https://github.com/dotnet/roslyn/pull/23656 🎉), so I suppose the NuGet packages will be obsolete in VS 15.6? What's your plan for SourceLink.Embed.AllSourceFiles?

ctaggart commented 6 years ago

We can retire the nupkg for SourceLink 3.0 now that the feature will be built in. https://github.com/dotnet/roslyn/issues/19127