search

ctaggart / SourceLink

Source Code On Demand
MIT License
357 stars 55 forks source link

help enable source link for Newtonsoft.Json #307

Closed ctaggart closed 5 years ago

ctaggart commented 6 years ago

I created a pull request https://github.com/JamesNK/Newtonsoft.Json/pull/1555.

Meanwhile, I uploaded a nupkg to try out. https://www.myget.org/feed/Packages/sourcelink

You can try it out with the json branch in sourcelink-test: https://github.com/ctaggart/sourcelink-test/tree/json

ctaggart commented 6 years ago

Here is a video demo using Visual Studio 2017 15.5.2: https://youtu.be/gyRGhCQPkB4

MagicAndre1981 commented 6 years ago

I added your feed to NuGet options, but I get an error when I try to browse your feed in VS2017 nuget management UI for available packages:

[source link enabled packages] 'doctype' is an unexpected token. The expected token is 'DOCTYPE'. Line 1, position 3.

ctaggart commented 6 years ago

@MagicAndre1981 That is a standard NuGet feed from myget. They have instructions here: https://www.myget.org/feed/Details/sourcelink

It looks like this from Visual Studio 2017 15.5.2: image

How I have it configured in VS: image

MagicAndre1981 commented 6 years ago

ok, got it working now. I was not able to open the instruction page as guest.

That experience was great 😍😍😍. Can you please enable it for SignalR Client 2.2.2, too? I have issues that I would like to debug easier.

ctaggart commented 6 years ago

@MagicAndre1981, glad you liked it. SignalR falls in the aspnet camp. You will need to ask them to enable source link. https://github.com/ctaggart/SourceLink/issues/173. Unfortunately, they are still trying to figure things out https://github.com/aspnet/Universe/issues/131.

MagicAndre1981 commented 6 years ago

ok, it would be still nice if you could provide such a package Microsoft.AspNet.SignalR.Client -Version 2.2.2-pdb until they provide it officially 😇

MagicAndre1981 commented 6 years ago

Can you please help the Xamarin guys to use it? Their old school way sucks:

https://blog.xamarin.com/debugging-xamarin-forms/

ctaggart commented 6 years ago

@MagicAndre1981 good idea. https://github.com/xamarin/Xamarin.Forms/issues/2165 That article is a great example of the steps required before enabling source link.

ctaggart commented 6 years ago

Looks like this is going to happen soon using https://github.com/dotnet/sourcelink https://github.com/JamesNK/Newtonsoft.Json/pull/1746

ctaggart commented 6 years ago

My blog about this finally happening: http://blog.ctaggart.com/2018/06/newtonsoftjson-enabling-source-link.html