search

ctaggart / SourceLink

Source Code On Demand
MIT License
356 stars 55 forks source link

Unable to get sourcelink working with net461 TFM #332

Closed fubar-coder closed 6 years ago

fubar-coder commented 6 years ago

Things I checked

  1. SourceLink V1 disabled
  2. SourceLink V2 enabled
  3. Tried with "Just my code" both enabled and disabled

Test I tried

  1. Create new-style csproj
  2. Used the NuGet Newtonsoft.Json package from https://www.myget.org/F/sourcelink/api/v3/index.json
  3. Tried to step into var output = JObject.Parse("{ \"a\": 1 }")

Result

Got a step-over instead of step-into.

Environment

ctaggart commented 6 years ago

If you pull down the Newtonsoft.Json package from nuget.org, it does not have SourceLink info yet. You can see https://github.com/ctaggart/SourceLink/issues/307#issuecomment-356639249 for a demo. I'm using a custom build of it that you can try. I uploaded it to a myget repo.

fubar-coder commented 6 years ago

@ctaggart I already used your version from your myget feed. It works for .NET Core App 2.0, but not for .NET Framework.

ctaggart commented 6 years ago

Can you try the next SourceLink version at https://github.com/dotnet/sourcelink ?

ctaggart commented 6 years ago

You can see examples of using the new Microsoft.SourceLink in #340 and #341