search

ctaggart / SourceLink

Source Code On Demand
MIT License
357 stars 55 forks source link

PackageReference to SourceLink.Create.GitLab fails to build (syntax error in targets file) #333

Closed tylerohlsen closed 6 years ago

tylerohlsen commented 6 years ago

Adding a package reference to SourceLink.Create.GitLab version 2.8.0 and 2.8.1 both give a compile error immediately due to a syntax error in the included targets file.

error MSB4024: The imported project file "C:\Users\myUser\.nuget\packages\sourcelink.create.gitlab\2.8.1\build\SourceLink.Create.GitLab.targets" could not be loaded. The 'SourceLink.Create.GitLab.CreateTask' start tag on line 25 position 6 does not match the end tag of 'SourceLink.Create.GitHub.CreateTask'. Line 36, position 7.

This line incorrectly closes the tag with GitHub in the name instead of GitLab.

(Is this the right repository or should I create the issue here?)

ctaggart commented 6 years ago

This is the right spot for that package.

ctaggart commented 6 years ago

Please make a pull request

tylerohlsen commented 6 years ago

Yep. Here: https://github.com/ctaggart/SourceLink/pull/337

ctaggart commented 6 years ago

It will be in 2.8.2, out soon