search

ctaggart / SourceLink

Source Code On Demand
MIT License
356 stars 55 forks source link

new SourceLink.PaketFiles #347

Closed ctaggart closed 5 years ago

ctaggart commented 6 years ago

This is going to be a provider that source links instead of embedding the git referenced paket files. https://fsprojects.github.io/Paket/git-dependencies.html

https://github.com/dotnet/sourcelink/tree/master/src/SourceLink.GitHub

It needs to get the checksum from the paket.lock file for each source file and add that to the entries.

@tmat I'm assuming that this could live here and not https://github.com/dotnet/sourcelink as Microsoft.SourceLink.PaketFiles. Any preferences?

This & EmbedUntrackedSources make SourceLink.Embed.PaketFiles not necessary.

ctaggart commented 6 years ago

Use SourceRoot as described in https://github.com/ctaggart/SourceLink/issues/305#issuecomment-355887447

tmat commented 6 years ago

Yes, let's keep it here.

ctaggart commented 6 years ago

Paket.Dependencies.TryLocate .GetLockFile https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/PublicAPI.fs#L51

I was originally thing Paket GitHub dependencies https://fsprojects.github.io/Paket/github-dependencies.html

There are also Paket Git dependencies https://fsprojects.github.io/Paket/git-dependencies.html These would ideally hook into the Microsoft.SourceLink.GitHub and friends code

ctaggart commented 5 years ago

This is low priority for me since I prefer to use the build int nuget support with dotnet core. Happy to accept pull requests.