Closed ctaggart closed 5 years ago
https://github.com/Microsoft/visualfsharp/blob/master/build/targets/GenerateAssemblyAttributes.targets shows July 18th, but still doesn't work in .NET Core SDK 2.1.402 https://github.com/dotnet/core/blob/master/release-notes/2.1/2.1.4/2.1.4-download.md
The fsproj has <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
.
Workaround is probably <NoWarn>FS2003</NoWarn>
.
Quick question, I've never seen a Directory.Build.props
file. Why would the SourceLink configuration sit there rather than inside the Giraffe.fsproj
file?
It is just an easy way to apply it to all projects. It is the normal way I add it to most solutions. Feel free to put in the fsproj if you like that better.
Ok cool, thanks for clarification! It's good to know, but currently the Giraffe repo has only one project so I think I'll move it in there. I will also add it to the other Giraffe repos (Giraffe.Razor, Giraffe.DotLiquid, etc.) :)
I tested that it is working for Giraffe 3.0.0. Congrats on 3.0.0! 🎉
PS C:\Users\taggac> sourcelink print-json "C:\Users\taggac\Downloads\giraffe.3.0.0\lib\netstandard2.0\Giraffe.pdb"
{"documents":{"C:\\projects\\giraffe\\*":"https://raw.githubusercontent.com/giraffe-fsharp/Giraffe/a036cfe7d3ef52af68ed1d43b5fe477d4c10a211/*"}}
PS C:\Users\taggac> sourcelink test "C:\Users\taggac\Downloads\giraffe.3.0.0\lib\netstandard2.0\Giraffe.pdb"
sourcelink test passed: C:\Users\taggac\Downloads\giraffe.3.0.0\lib\netstandard2.0\Giraffe.pdb
I see it depends on TaskBuilder.fs 2.0.0 or higher. If you use 2.1.0, it also has SourceLink enabled. https://github.com/rspeele/TaskBuilder.fs/pull/24
Thanks! This will be in the next release: https://github.com/giraffe-fsharp/Giraffe/commit/81b61b311d659d5cbbcad7dfc9ccb3f8a68437dd
The AppVeyor build failed with:
Usually that is a warning and not a failure. It shouldn't even be a warning and that was fixed on July 18th:
The .NET SDK version is pinned. I'll try updating it.