search

ctaggart / SourceLink

Source Code On Demand
MIT License
356 stars 55 forks source link

Dotnet global tool test - connection failed... #381

Open warrenbuckley opened 5 years ago

warrenbuckley commented 5 years ago

Hi @ctaggart I get the following when trying this command sourcelink test UmbracoCms.Core.8.1.0.nupkg

A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond

I assume because this could be timing out due to looking up & checking a large number of files?

ctaggart commented 5 years ago

@warrenbuckley I think so.

warrenbuckley commented 5 years ago

@ctaggert ok will see if I can reproduce with the source code & see if I can submit a PR

shiftkey commented 4 years ago

I've hit this pretty reliably on GitHub Actions (Windows target) where midway through scanning four assemblies in a NuGet package it'll report a generic networking error.

Example run: https://github.com/octokit/octokit.net/pull/2070/checks?check_run_id=413892676

Testing sourcelink info in packaging/Octokit.0.37.0-PullRequest2070-0028.nupkg
sourcelink test passed: lib/net45/Octokit.dll
sourcelink test passed: lib/net46/Octokit.dll
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond
An error occurred when executing task 'TestSourceLink'.
Error: Sourcelink test failed!

It's a blocker on migrating to using Actions for this project, so I'm looking into wrapping the HttpClient activity in tracing so we can experiment with approaches to make this more resilient in these environments and situations. If I settle on a satisfactory solution I'll propose a PR.