search

ctaggart / SourceLink

Source Code On Demand
MIT License
356 stars 55 forks source link

Use SourceLinkMap from Microsoft.SourceLink.Tools to implement SourceLink JSON parsing. #389

Open tmat opened 4 years ago

tmat commented 4 years ago

Creating and using a source package that includes the implementation is tracked by https://github.com/dotnet/sourcelink/issues/443. Fixes https://github.com/ctaggart/SourceLink/issues/386.

tmat commented 4 years ago

@ctaggart Please take a look.

tmat commented 4 years ago

/cc @dougbu

ctaggart commented 4 years ago

The azure-pipelines failure looks like a build environment issue:

D:\a\1\s\dotnet-sourcelink-shared\SourceLinkMap.cs(117,20): error CS8107: Feature 'default literal' is not available in C# 7.0. Please use language version 7.1 or greater. [D:\a\1\s\dotnet-sourcelink\sourcelink.csproj]

Looks good. I'll probably just stick to AppVeyor to get this out.

ctaggart commented 4 years ago

I can push a 3.2.0 here next week when you are ready. https://www.nuget.org/packages/sourcelink/

It would be great if you were to replace this global test tool with one from dotnet/sourcelink in the future.