search

ctaggart / froto

Froto: F# Protocol Buffers
MIT License
146 stars 27 forks source link

Update NB.GV version to recognize GitHub Actions v2 #111

Closed AArnott closed 5 years ago

AArnott commented 5 years ago

Testing fix for https://github.com/AArnott/Nerdbank.GitVersioning/issues/375

Do not complete this PR. You will want an official NB.GV version -- not this PR build.

AArnott commented 5 years ago

OK, well I'm not sure why the action is failing, but we're not going to see PublicRelease=true unless this is actually building in a public branch in your repo anyway. Can you take my commit and make a local branch called stable-version-test and push it to your repo and check the result?

ctaggart commented 5 years ago

It works!

image

https://github.com/ctaggart/froto/pull/111/checks?check_run_id=196042834

ctaggart commented 5 years ago

It passed my second test too. I created a branch and squash merged it in to the original test branch. All the versioning worked as I expected. Thank you!