Closed jhugard closed 8 years ago
Implement Features from Issue #19
Needs final code review before merging to master. Rework WireFormat to support serialization Implement ZeroCopyBuffer to reduce memory copies and array allocations Create framework for serialization, with an eye to eventual F# code generation
Needs final code review before merging to master.
Update: All of the above are now implemented, with unit tests.
Remaining work:
Would very much like a code review & feedback on the overall direction, in particular the serialization framework. Thanks!
Ready for code review.
Great work!
Implement Features from Issue #19
Update: All of the above are now implemented, with unit tests.
Remaining work:For proto2, missing required fields should cause exceptionFor proto2/proto3, need to elide default/zero values when serializingFor proto2, missing optional messages should probably be modeled as a Some typeWould very much like a code review & feedback on the overall direction, in particular the serialization framework. Thanks!