Shouldn't this be outside the for loop?

ctallec / world-models

Reimplementation of World-Models (Ha and Schmidhuber 2018) in pytorch

MIT License

568 stars 131 forks source link

Closed Fairasname closed 5 years ago

Fairasname commented 5 years ago

The variable _isbest is set to None each time inside the for loop, shouldn't it be outside the loop, as in trainvae.py?

AmazingAng commented 5 years ago

I think u are right. This replace the best model with current model every time.

Fairasname commented 5 years ago

Thanks!

leonardblier commented 5 years ago

@Ivorra You are totally right, this is a mistake. Could you make a Pull Request on this please? Thanks!